Skip to content

simulators/ethereum/consensus: split test suites#1130

Merged
fjl merged 4 commits intoethereum:masterfrom
winsvega:simargs
Jul 15, 2024
Merged

simulators/ethereum/consensus: split test suites#1130
fjl merged 4 commits intoethereum:masterfrom
winsvega:simargs

Conversation

@winsvega
Copy link
Copy Markdown

@winsvega winsvega commented Jun 27, 2024 •
edited
Loading

adds --sim.argument option to be set as env variable inside simulator dockers
this to run consensus tests on different revisions:

# run develop bc tests
./hive --sim ethereum/consensus --client go-ethereum  --sim.limit "/add11" 

# run legacy tests from constantinople fix to cancun
./hive --sim ethereum/consensus --client go-ethereum  --sim.limit "/add11"  --sim.argument "legacy-cancun"

# run legacy tests from frontier to constantinople
./hive --sim ethereum/consensus --client go-ethereum  --sim.limit "/add11"  --sim.argument "legacy"

we only need to regulaly run develop tests. and sometimes legacy tests. to save execution time.

@winsvega winsvega mentioned this pull request Jun 27, 2024
Closed
@marioevz marioevz requested a review from fjl July 11, 2024 20:11
@winsvega
Copy link
Copy Markdown
Author

winsvega commented Jul 11, 2024

@fjl how about this way?

@fjl
Copy link
Copy Markdown
Collaborator

fjl commented Jul 13, 2024 •
edited
Loading

I think what we should do is, expose the test groups as "suites", which is an existing concept in hive. Then you could run it like

# run legacy tests from constantinople fix to cancun
./hive --sim ethereum/consensus --client go-ethereum  --sim.limit "legacy-cancun/add11"

@fjl fjl changed the title consensus simulator args simulators/consensus: split test suites Jul 15, 2024
@fjl
Copy link
Copy Markdown
Collaborator

fjl commented Jul 15, 2024

I have implemented my suggestion and it works. You can select the test suites using --sim.limit.

@fjl fjl merged commit 6f37e79 into ethereum:master Jul 15, 2024
@fjl fjl changed the title simulators/consensus: split test suites simulators/ethereum/consensus: split test suites Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjl fjl Awaiting requested review from fjl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@winsvega @fjl